r.stahl accepted this revision. r.stahl added a comment. I can confirm the issue with my patch, so this piece of code needs to be removed.
As long as the following test still succeeds, this looks good to me. Back then, the analyzer was not able to cover that case without that addition. https://github.com/llvm/llvm-project/blob/main/clang/test/Analysis/globals.cpp#L110 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124621/new/ https://reviews.llvm.org/D124621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits