aaronpuchert added a comment. In D124606#3480281 <https://reviews.llvm.org/D124606#3480281>, @labath wrote:
> In D124606#3480164 <https://reviews.llvm.org/D124606#3480164>, @aaronpuchert > wrote: > >> An editor could inadvertently change the line endings, and someone might not >> notice before committing. > > From what I understood, most of these tests would immediately break (due to > hardcoded offsets) if the line endings were changed. Ok, that's a valid point. > The branch switching issue (discussed in D124563 > <https://reviews.llvm.org/D124563>) is one. That is an issue, but I don't think this change fixes it. D124563 <https://reviews.llvm.org/D124563> did normalize the file endings and switching between branches after that should work fine. Switching between branches before that will remain broken because the files had not been normalized. I don't think any change can fix that because they can't retroactively change the inconsistent snapshots. > We also ran into problems when importing this into our version control system > (as it did not do the .gitattributes conversion) -- although one could say > that is not an upstream problem... Got it, so some implementations simply can't deal with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
