erichkeane added a comment. In D122920#3479192 <https://reviews.llvm.org/D122920#3479192>, @yihanaa wrote:
>> While we'd usually be happy to take the fix-in-hand and apply it, part of >> the discussion on the other thread is whether to remove >> `__builtin_dump_struct` entirely. Because of that, I don't think we should >> make substantial changes in this area until it's clear we're keeping the >> builtin. > > Thanks for take a look, I agree to wait for the outcome of the discussion I think I disagree with Aaron. While, YES, we are likely to delete this in the near future, it doesn't mean we should leave it in a broken state in the meantime. WHILE all of this is likely to be deleted, it has value until we delete it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
