samitolvanen added a comment.

In D119296#3466217 <https://reviews.llvm.org/D119296#3466217>, @joaomoreira 
wrote:

> Oh, one other tiny detail I forgot to mention. I noticed that the tag is 
> pushing the functions 6 bytes forward, regardless of any prepending padding 
> nops that were added to ensure 16b alignment. It would be cool to care about 
> the proper function alignment and also to not emit dummy padding nops when 
> the padding area can be filled with the tag itself.

Looking at `MCAsmStreamer::emitValueToAlignment`, using a non-power of two 
alignment seems problematic. I suppose we could emit additional nops before the 
type identifier to maintain expected alignment for the function entry, but that 
would end up bloating the binary even more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119296/new/

https://reviews.llvm.org/D119296

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to