yaxunl added a comment.
need a test for the generated registration code
================
Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:98-104
+ // struct __tgt_image_info {
+ // int32_t version;
+ // int32_t image_number;
+ // int32_t number_images;
+ // char* offload_arch;
+ // char* target_compile_opts;
+ // };
----------------
I am wondering whether we should add a few more fields to make it more generic
for all offloading languages and platforms:
```
char* target_triple;
char* offloading_kind; // openmp, hip, etc
char* file_type; // elf, spirv, bitcode, etc
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124525/new/
https://reviews.llvm.org/D124525
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
