[PATCH] D124545: [HIP] Add HIP runtime library arguments for linker

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:681
+                                 ArgStringList &CmdArgs) const {
+  CmdArgs.push_back(
+      Args.MakeArgString(StringRef("-L") + RocmInstallation.getLibPath()));
----------------
tra wrote:
> Nit: `CmdArgs.append({ ... })` to add all arguments at once would be a bit 
> more readable (no `CmdArgs.push_back` littering space between args).
will do when committing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124545/new/

https://reviews.llvm.org/D124545

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits