hokein added inline comments.

================
Comment at: 
clang-tools-extra/clangd/refactor/tweaks/MemberwiseConstructor.cpp:182
+    if (!C.hasDefinition())
+      return Skip;
     // We can't always tell if C is copyable/movable without doing Sema work.
----------------
sammccall wrote:
> Fail instead?
`Fail` seems too strict, the tweak is entirely unavailable if there is any 
incomplete-type field decls in a class, I think it is still useful to make the 
tweak available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124154/new/

https://reviews.llvm.org/D124154

_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to