It was the previous revision that broke tests, http://reviews.llvm.org/rL273659. It moved ignoringImplicit to ASTMatcher, caused some namespace conflict in clang-tidy/misc/DanglingHandleCheck.cpp. And r273660 solves that, tests are not broken after this revision.
On Fri, Jun 24, 2016 at 12:32 PM Renato Golin <renato.go...@linaro.org> wrote: > On 24 June 2016 at 10:39, Cong Liu via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: congliu > > Date: Fri Jun 24 04:39:28 2016 > > New Revision: 273660 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=273660&view=rev > > Log: > > Remove ignoringImplicit from clang-tidy. > > Hi Cong, > > Isn't this leaving untested code in tree? Shouldn't you have reverted > the patch instead? > > cheers, > --renato >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
