cor3ntin marked an inline comment as done.
cor3ntin added inline comments.
================
Comment at: clang/lib/Sema/SemaLambda.cpp:539-546
void Sema::buildLambdaScope(LambdaScopeInfo *LSI, CXXMethodDecl *CallOperator,
SourceRange IntroducerRange,
LambdaCaptureDefault CaptureDefault,
SourceLocation CaptureDefaultLoc,
- bool ExplicitParams, bool ExplicitResultType,
- bool Mutable) {
+ bool ExplicitParams, bool Mutable) {
buildLambdaScopeCaptures(LSI, CallOperator, IntroducerRange, CaptureDefault,
CaptureDefaultLoc, ExplicitParams, Mutable);
----------------
aaron.ballman wrote:
> IIRC, we added `buildLambdaScope()` quite recently, so perhaps that function
> should go away now and callers just call `buildLambdaScopeCaptures()`
> directly?
I got rid of `buildLambdaScopeCaptures` - as we also set things related to
parameters / mutable, it makes more sense that way
================
Comment at: clang/lib/Sema/SemaLambda.cpp:1377
- ContextRAII ManglingContext(*this, Class->getDeclContext());
+ Method->setInnerLocStart(LambdaLoc);
+ CompleteLambdaCallOperator(
----------------
aaron.ballman wrote:
> Out of curiosity, why isn't this part of `CompleteLambdaCallOperator()` like
> all the other setters? (Should template instantiation also be setting this?)
No good reason - and template should have set this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124012/new/
https://reviews.llvm.org/D124012
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
