bnbarham accepted this revision.
bnbarham added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Lex/HeaderSearch.cpp:584
// If it is known and in some other directory, fail.
- if (CacheEntry.Directory && CacheEntry.Directory != getFrameworkDir())
+ if (CacheEntry.Directory && *CacheEntry.Directory != getFrameworkDir())
return None;
----------------
================
Comment at: clang/lib/Lex/HeaderSearch.cpp:607
// If the framework dir doesn't exist, we fail.
auto Dir = FileMgr.getDirectory(FrameworkName);
if (!Dir)
----------------
Is the plan to do these ones in later commits? Ie. this just does what's needed
for `FrameworkCacheEntry`?
================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1192
// framework.
CacheLookup.second.Directory = *Dir;
}
----------------
Don't need the `*`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123854/new/
https://reviews.llvm.org/D123854
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
