aaron.ballman accepted this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment.
In D121984#3453976 <https://reviews.llvm.org/D121984#3453976>, @kito-cheng wrote: >> Thank you for the explanation. I still don't think this is really "Support" >> material, but I'm also struggling to think of a better place to put it in an >> existing directory in Clang aside from Basic, but that would still be a bit >> of a layering violation it feels like. So I think I'm convinced that Support >> is a reasonable place to put it. > > Actually I tried to put that on clang/Basic before, and end up with the > clang/Basic is depended on clang-tblgen, and that made clang-tblgen depend on > clang/Basic...then CMake report error for circular dependency :P Yup, that's exactly the issue I was thinking we'd hit. :-) >> Should it live within a RISCV direction inside of the Support directory? Or >> should we use folders like that for host platform support files instead of >> target platform support files (as the LLVM Support directory appears to do)? > > I saw LLVM/Support are just target specific file on the folder instead of > many target folder, I guess there should not be too much target specific > files in clang/Support, and we could reorg the folder organization once it > getting complicated? What do you think? Yeah, I think that's likely reasonable. Giving my LGTM but adding @rsmith in case he has any code owner concerns over it. If you don't hear any concerns by Tue of next week, I think you're fine to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121984/new/ https://reviews.llvm.org/D121984 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
