bnbarham accepted this revision. bnbarham added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Lex/HeaderSearch.cpp:1583 + ::getTopFrameworkDir(FileMgr, FrameworkName, SubmodulePath); + assert(TopFrameworkDir && "Could not find the top-most framework dir"); ---------------- jansvoboda11 wrote: > bnbarham wrote: > > Can we just return false in this case, or is it definitely always a logic > > error? > I agree returning `false` here would be better, but I wanted to keep this > patch as NFC as possible. How about I make that change in a follow-up patch? Sure. It would have been a segfault before, so I assume it must never happen anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123771/new/ https://reviews.llvm.org/D123771 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
