curdeius added inline comments.
================
Comment at: clang/lib/Format/FormatTokenLexer.h:117-120
+ struct MacroTokenInfo {
+ TokenType Type;
+ bool Finalized;
+ };
----------------
ksyx wrote:
> Would making constructor of `struct MacroTokenInfo` having default parameter
> or overloading it help avoiding the change of adding `, /*Finalized=*/false`
> to the existing initializer lists?
I've thought about it, but it would mean that we have a non-explicit 1-arg
ctor. I'm not a big fan of these as they trigger implicit conversions.
I can do though:
```
struct MacroTokenInfo {
TokenType Type;
bool Finalized{false};
};
```
but we'd still need adding braces in:
```
Macros.insert({Identifier, {TT_ForEachMacro}});
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123676/new/
https://reviews.llvm.org/D123676
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
