manas added a comment.

@steakhal apologies for holding onto this for so long. I managed to fix 
previously untestable test cases. The issue was that I was building expressions 
as `(u1 != u2) != 0` and the solver was canonicalizing this to an equivalent 
`BO_EQ` expression. That's why, it wasn't reaching 
`VisitBinaryOperator<BO_NE>()`. So I changed all tests as following: `(u1 != 
u2)` (removing the latter `!= 0` part. Also, I utilized the 
`getConcreteValue()` for checking of single APSInt in the RangeSets.

Apart from this, I am building for the coverage reports (which I will upload 
later).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112621/new/

https://reviews.llvm.org/D112621

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to