aaron.ballman added inline comments.
================
Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:47-48
// Note TableGen depends on the order above. Do not add or change the
order
// without adding related code to TableGen/ClangAttrEmitter.cpp.
/// Context-sensitive version of a keyword attribute.
----------------
beanz wrote:
> aaron.ballman wrote:
> > Should this comment now move down a bit?
> I'm struggling a bit with what that comment is referring to, and I feel like
> I'm missing something obvious. If you change the order of any of the cases
> `AS_ContextSensitiveKeyword` or earlier in the list, things start breaking.
> Specifically putting `AS_HLSLSemantic` above `AS_ContextSensitiveKeyword`
> breaks parsing context sensitive keywords...
>
> I'm clearly missing something...
>
> That said, I can add a new case after `AS_ContextSensitiveKeyword` before
> `AS_HLSLSemantic` and it all still works fine.
>
> With my current understanding, I'm not sure moving the comment makes sense,
> but I could expand the comment. Thoughts?
This is where that comment ultimately came from:
https://github.com/llvm/llvm-project/commit/be89f4c5655d01dd44d6c82a4d5e44820a81f404
Based on that, I don't think we need to move the comment after all.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122699/new/
https://reviews.llvm.org/D122699
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
