FabioRS added a comment. In D122698#3430211 <https://reviews.llvm.org/D122698#3430211>, @sammccall wrote:
> You're right about the out-of-line function case. Current version looks great! > I had to rework the logic around merging the edits a little, it wasn't quite > correct and was hitting assertions (not sure if you were seeing these > locally, but phabricator is not currently running the clangd tests properly). > > Thanks again, landing now. Thanks. Here the tests are passing, maybe something is missing in my compilation setup... There are these unsupported tests, but I was thinking they are for another architeture. ninja check-clangd [1/2] Running the Clangd regression tests llvm-lit: /homessddata/Projects/llvm-project/llvm/utils/lit/lit/llvm/config.py:438: note: using clang: /homessddata/Projects/llvm-project/build/bin/clang Testing Time: 3.26s Unsupported: 6 Passed : 1129 You are welcome. Thank you for your patience and time, I am glad to help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122698/new/ https://reviews.llvm.org/D122698 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits