aaron.ballman added a comment.

In D116203#3425512 <https://reviews.llvm.org/D116203#3425512>, @cjdb wrote:

> I've noticed that libstdc++ has `using __remove_cv = typename 
> remove_cv<T>::type`, which causes Clang to chuck a wobbly. Changing from 
> `KEYWORD` to `TYPE_TRAIT_1` didn't seem to fix anything.
> Is there a way we can work around this, or should we just rename 
> `__remove_cv` and friends to something else?

You could work around it by taking note that you're in a libstdc++ system 
header and do a special dance, but because these are in the implementation's 
namespace, I think it's probably kinder for everyone to just pick a different 
name.

If you wanted to be especially mean, you could go with `__remove_cvr`, but I'd 
suggest `__remove_cv_qualifiers` instead. However, what about `restrict` 
qualifiers? We support them in C++: https://godbolt.org/z/11EPefhjf


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116203/new/

https://reviews.llvm.org/D116203

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to