ymandel marked an inline comment as done. ymandel added inline comments.
================ Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1904 - const auto *FooVal = - cast<IntegerValue>(Env.getValue(*FooDecl, SkipPast::None)); - const auto *BarVal = ---------------- sgatev wrote: > Why not assert the type of the value in this test and in `IntegralCast` below? Sure, but went with an ASSERT, since it gives better error messages when it fails (rather than cast, which will crash the test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123037/new/ https://reviews.llvm.org/D123037 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
