scott.linder added a comment. In D121951#3414271 <https://reviews.llvm.org/D121951#3414271>, @sameerds wrote:
> In D121951#3411856 <https://reviews.llvm.org/D121951#3411856>, @scott.linder > wrote: > >> @yaxunl Does excluding device-libs via COV_None make sense? >> >> @sameerds Would you still rather we just not add this attribute in the >> frontend at all? I'm OK with it if that is the consensus > > Yes, I still think there is no need to emit that attribute in the frontend. > It will always be inferred by the Attributor when optimization is enabled. > This also eliminates the check for COV_None and there seems to be some > uncertainty about COV_None anyway. This also eliminates the updates to all > the tests where the no-hostcall-ptr attribute does not actually matter. If > ever we need to check if hostcall is being used on OpenCL and COV < 5, we > should do it per feature and inform the user appropriately. OK, that makes sense to me. I think I was not interpreting the purpose of the attributes correctly, but if they are essentially just optimization remarks then I don't have any issue with not ensuring they are present at -O0. I updated the patch, let me know what you think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121951/new/ https://reviews.llvm.org/D121951 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
