dexonsmith added a comment.

In D121733#3403995 <https://reviews.llvm.org/D121733#3403995>, @rnk wrote:

> Ignoring the ".." path components for the moment, is this patch good to go as 
> is? It doesn't affect that behavior.

Besides the test failure, the other thing is considering what to do with 
`getDirectoryRef()`, which might make sense to update in the same patch to 
avoid inconsistency. See 1st/2nd bullets of 
https://reviews.llvm.org/D121733#3393732.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121733/new/

https://reviews.llvm.org/D121733

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to