hokein marked 13 inline comments as done.
hokein added a comment.

splitting the forest data structure to https://reviews.llvm.org/D122139, 
comments around Forest.h/.cpp should be addressed.


================
Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Forest.h:57
+  };
+  uint32_t startLoc() const { return StartLoc; }
+
----------------
sammccall wrote:
> maybe startIndex or startToken? Loc reminds me too much of SourceLocation...
renamed to `startTokenIndex`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121150/new/

https://reviews.llvm.org/D121150

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to