erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
Generally looks fine to me. Just 1 test that looks suspicious. ================ Comment at: clang/test/Sema/attr-cpuspecific.c:133 -// FIXME: Declaration of a non-overloadable function when more than one -// FIXME: multiversion function declarations are present results in an -// FIXME: assertion failure. int __attribute__((cpu_dispatch(generic))) bad_overload3(void); int __attribute__((cpu_specific(ivybridge))) bad_overload3(void); ---------------- In what way is this test different than bad_overload1? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121959/new/ https://reviews.llvm.org/D121959 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
