owenpan added a comment.
In D121755#3391606 <https://reviews.llvm.org/D121755#3391606>, @MyDeveloperDay
wrote:
> This just made a 300 lines function and a 500 line function with minimal
> comments into a 800 line function.. For no real benefit?
>
> Because from what I can tell you haven't worked on small clang-format issues
> you won't know that I often put a breakpoint in the spaceRequiredBetween, if
> it calls out into that function I now know where its covered.
>
> I think if you had fixed a miriade of issues like "I want a space between
> `@` and `{`" then you would have understood why breaking the 800 lines at
> least in 2 can be helpful even a little.
>
> I know its not idea, but I'm not sure that the first step I'd make is to join
> 2 functions to make one massive function, for me my greatest frustration is
> the lack of comments and the if statements that have about 8 different
> clauses..
>
> A better developer than me once said "Deal with the case you want and get
> out"...
+1.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121755/new/
https://reviews.llvm.org/D121755
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
