owenpan added inline comments.
================
Comment at: clang/lib/Format/WhitespaceManager.h:321
+ }
auto Start = (CellStart + RowCount * CellCount);
auto End = Start + Offset;
----------------
MyDeveloperDay wrote:
> Ultimately these calculations are incorrect unless every CellCount for every
> row is the same, and for non-square they are not, this always had me confused
> as to why it starts at 1?
> Ultimately these calculations are incorrect unless every CellCount for every
> row is the same, and for non-square they are not, this always had me confused
> as to why it starts at 1?
Because the loop starts at `CellStop->NextColumnElement`, the 2nd row of the
column?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121069/new/
https://reviews.llvm.org/D121069
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
