rsmith added a comment.

The modules side of this looks good to me, and logically changing the lexical 
decl context in an interface to be that interface makes a lot of sense, but I 
agree with @rjmccall that it's hard to predict what the consequences of that 
change might be. Can you also test this against some body of real-world code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118525/new/

https://reviews.llvm.org/D118525

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D118525: ... Volodymyr Sapsai via Phabricator via cfe-commits
    • [PATCH] D118... John McCall via Phabricator via cfe-commits
    • [PATCH] D118... Volodymyr Sapsai via Phabricator via cfe-commits
    • [PATCH] D118... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D118... Volodymyr Sapsai via Phabricator via cfe-commits

Reply via email to