yaxunl added a comment.

In D120298#3341250 <https://reviews.llvm.org/D120298#3341250>, @tra wrote:
> LGTM with a minor nit.
>
>> Also -DHIP_API_PER_THREAD_DEFAULT_STREAM is passed to clang -cc1 to enable 
>> other per-thread stream
>
> You may want to rephrase patch description it a bit to match the latest code. 
> "HIP_API_PER_THREAD_DEFAULT_STREAM macro is set if ..."

will fix commit message when committing. thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120298/new/

https://reviews.llvm.org/D120298

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to