cor3ntin added a comment.

I like this approach. it seems a lot easier to maintain as people don't have to 
remember to use LangOptionsBase to not degrade performance



================
Comment at: clang/include/clang/Lex/Lexer.h:94
+  // LangOpts enabled by this language.
+  const LangOptions &LangOpts;
+
----------------
Should we add a comment to explain why this is a reference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120334/new/

https://reviews.llvm.org/D120334

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to