[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

[Nikita Popov via Phabricator via cfe-commits]

nikic added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6067
+  if (VPtr) {
+    VOpVal = {VPtr, VPtr->getType()->getPointerElementType(),
+              V->getType().isVolatileQualified(),
----------------
Please avoid adding new calls to getPointerElementType(). See 
https://github.com/llvm/llvm-project/commit/b1863d82454b2905db8b492bea0ce8a260362645
 for a way to avoid it in this context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120290/new/

https://reviews.llvm.org/D120290

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits