peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:5 + // AARCH64-LABEL: @add_float_rr( + // AARCH64: fadd reassoc nnan ninf nsz arcp afn half + // AARCH64-NOT: fadd ---------------- peterwaller-arm wrote: > My read is that this appears to be testing both -ffast-math and _Float16. Do > we want to be testing both these things at once like this, can anyone comment? > > My preference would be to have these test only the operators, and not the > flags, and then maybe have a single test which does > https://clang.llvm.org/docs/LanguageExtensions.html#extensions-to-specify-floating-point-flags > ``` > #pragma clang fp contract(fast) > ``` > > and verifies that the flags are present. > Discussed off-review: concluded for now that a no-optimizations test with no fast math flags seems reasonable, to address @fhahn's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119926/new/ https://reviews.llvm.org/D119926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
