jansvoboda11 added inline comments.
================ Comment at: clang/include/clang/Lex/HeaderSearch.h:185 + /// Get search directory stored at the index. + DirectoryLookup &get(HeaderSearch &HS) const; +}; ---------------- ahoppen wrote: > I would have expected these to be methods on `HeaderSearch`. Is there a > particular reason why these are methods on `SearchDirIdx`? No particular reason. I agree this makes more sense on `HeaderSearch`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119825/new/ https://reviews.llvm.org/D119825 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits