berenm added a comment. I think it's better to update the diff with full context (git diff -U999999) rather than attach the file, in order to have it integrated into phabricator diff view. Or use the arcanist command-line tool, which should do it for you.
Except from that, from a quick reading it looks good to me and I'm happy that someone fixed theses cases, I see them from time to time actually but never had time to work on a proper fix. Repository: rL LLVM http://reviews.llvm.org/D21279 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
