kuhar added a comment.

Thanks for working on this, @xbolva00! I don't know this part of the codebase, 
so won't comment on the patch itself. Just a few questions/suggestions:

1. Do you plan to also add `inline` and `flatten`?

2. When I worked on my implementation, I remember that I also ran into the 
issue of conflicting attributes. I default to whatever the inliner behavior was 
at the time, but a few folks pointed out to me that this can be very confusing. 
I think this needs thorough documentation / testing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119061/new/

https://reviews.llvm.org/D119061

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to