jlebar added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322
ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const {
- if (getContext().getLangOpts().HIP) {
+ if (getContext().getLangOpts().CUDAIsDevice) {
// Coerce pointer arguments with default address space to CrossWorkGroup
----------------
I am surprised by this change. Is the language mode HIP only when compiling
for device? Or are you intentionally changing the behavior in HIP mode?
Same in SPIR.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119207/new/
https://reviews.llvm.org/D119207
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
