LegalizeAdulthood added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:251 + if (InsertPos.isValid()) + InvalidFix |= InsertPos.isMacroID(); + else ---------------- I'm not a fan of using bit-wise operators on booleans, but I see that the code for this check was already doing that. (See https://github.com/llvm/llvm-project/issues/40307) ================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:293 << Field; if (!InvalidFix) { + StringRef NewInit = Lexer::getSourceText( ---------------- I'm not a fan of double negatives either `:)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118927/new/ https://reviews.llvm.org/D118927 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
