craig.topper added inline comments.
================ Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:74 +// zbkb extension +TARGET_BUILTIN(__builtin_riscv_brev8, "ZiZi", "nc", "zbkb") ---------------- Capital Z ================ Comment at: clang/lib/Basic/Targets/RISCV.cpp:198 + ISAInfo->hasExtension("zk")) + Builder.defineMacro("__riscv_crypto"); } ---------------- This define doesn't seem very useful. It just tells you that you have some crypto instructions, but not which ones. ================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18888 + + // zbkx + case RISCV::BI__builtin_riscv_xperm8: ---------------- Capital Z Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits