njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:239
+ const ast_matchers::BoundNodes &Result) const {
+ if (CurrentlyProcessing)
+ CurrentlyProcessing->onProcessingCheckStart(CheckName, Result);
----------------
LegalizeAdulthood wrote:
> We repeat this `if (CurrentlyProcessing)` fragment 3 times...
> Maybe initializing to a Null Object would be better?
I don't think thats an improvement, as if we aren't in a context where the
stack trace would be emitted, we don't want to be storing the state on each
match.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118520/new/
https://reviews.llvm.org/D118520
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
