Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.h:33 +/// declarations in header files. True by default. +/// For the user-facing documentation see: +/// http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-inline-const-variables-in-headers.html ---------------- I think this is excessive comment. It's regular convention. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-use-inline-const-variables-in-headers.rst:6 + +Finds non-inline const variables definitions and extern const variables +declarations in header in header files. Non-inline const variables make ---------------- Please synchronize first statement with Release Notes. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-use-inline-const-variables-in-headers.rst:53 + A comma-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no ---------------- Please highlight option values in this section with single back-ticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ https://reviews.llvm.org/D118743 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
