sammccall added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/Tweak.h:85 + /// Merge the replacement's edit in the file corresponding to Loc. + /// Fails if we cannot figure out the absolute path for the corresponding ---------------- I don't think mergingEdit is a great API (a few issues, including not enough use cases to know if it's right). Rather than try to polish it here, can we just simulate it in the caller? DefineInline.cpp has an example of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits