dmgreen added a reviewer: samparker.
dmgreen added inline comments.
================
Comment at:
llvm/test/CodeGen/ARM/hoist-and-by-const-from-lshr-in-eqcmp-zero.ll:498
+; THUMB8-NEXT: it pl
+; THUMB8-NEXT: lslpl.w r1, r0, r
; THUMB8-NEXT: lsl.w r0, r0, r2
----------------
Can you make sure you run update_ll_test_checks on this file? It should fill in
all these check lines for you.
================
Comment at: llvm/test/CodeGen/ARM/ifcvt-branch-weight.ll:22
+; CHECK: bb.1.bb2:
+; CHECK: successors: %bb.2(0x40000000)
----------------
I'm not sure this is still checking anything useful. How has the full output
changed? Is there not a block with two outputs anymore?
================
Comment at: llvm/test/CodeGen/ARM/speculation-hardening-sls.ll:38
; NOHARDENARM: {{bxgt lr$}}
-; NOHARDENTHUMB: {{bx lr$}}
; ISBDSB-NEXT: dsb sy
----------------
What happened to this check line? Should it be bxgt lr now?
================
Comment at: llvm/test/CodeGen/ARM/speculation-hardening-sls.ll:50
+; CHECK: sdiv
+; CHECK: sdiv
; CHECK: {{bx lr$}}
----------------
Why are these removed?
================
Comment at: llvm/test/CodeGen/Thumb2/v8_IT_3.ll:4
; RUN: llc < %s -mtriple=thumbv8 -arm-atomic-cfg-tidy=0 -relocation-model=pic
| FileCheck %s --check-prefix=CHECK-PIC
-; RUN: llc < %s -mtriple=thumbv7 -arm-atomic-cfg-tidy=0 -arm-restrict-it
-relocation-model=pic | FileCheck %s --check-prefix=CHECK-PIC
+; RUN: llc < %s -mtriple=thumbv7 -arm-atomic-cfg-tidy=0 -arm-restrict-it
-relocation-model=pic | FileCheck %s --check-prefix=CHECK-PIC-RESTRICT-IT
--check-prefix=CHECK-RESTRICT-IT
----------------
I'm not sure what this test is doing. Can you just remove -arm-restrict-it and
update the check lines?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118044/new/
https://reviews.llvm.org/D118044
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
