aeubanks added inline comments.

================
Comment at: clang/lib/CodeGen/Address.h:70
+    unsigned AlignLog = (Pointer.getInt() << 3) | ElementType.getInt();
+    return CharUnits::fromQuantity(1UL << AlignLog);
+  }
----------------
LegalizeAdulthood wrote:
> This is causing warnings to be emitted:
> ```
> clang\lib\CodeGen\Address.h(69,1): warning C4334: '<<': result of 32-bit 
> shift implicitly converted to 64 bits (was 64-bit shift intended?) 
> [D:\legalize\llvm\llvm-project\build\tools\clang\lib\CodeGen\obj.clangCodeGen.vcxproj]
> ```
Should be fixed by eee97f1617c94b8


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117262/new/

https://reviews.llvm.org/D117262

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to