vabridgers marked an inline comment as done.
vabridgers added inline comments.


================
Comment at: clang/test/Analysis/cstring-checker-addressspace.c:14
+// Copy from host to device memory.
+DEVICE void *memcpy(DEVICE void *dst, const void *src, unsigned long len);
+
----------------
steakhal wrote:
> Please try to trigger the test using some suffix for the `memcpy`.
> E.g.: `memcpy_host2device` or something similar.
Please see latest comment. I tried this, but found a memcpy name with some 
suffix must be builtin. I could not find a way to repro this, but I was able to 
repro the negative case with the changes I just uploaded amending this review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118050/new/

https://reviews.llvm.org/D118050

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to