eopXD added inline comments.
================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:149
RV64 = 1 << 5,
+ VectorMaxELen32 = 1 << 6,
+ VectorMaxELen64 = 1 << 7,
----------------
craig.topper wrote:
> Do we need VectorMaxELen32 isn't that the minimum?
Yes you are correct. We don't need it.
================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:804
+ RISCVPredefinedMacros |= RISCVPredefinedMacro::Zfh;
else if (T->isFloatVector(32) || T->isFloat(32))
+ RISCVPredefinedMacros |= RISCVPredefinedMacro::F;
----------------
craig.topper wrote:
> Can D and F go away?
Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112986/new/
https://reviews.llvm.org/D112986
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
