aaron.ballman added a comment.

In D117232#3258309 <https://reviews.llvm.org/D117232#3258309>, @melver wrote:

> Looks like https://reviews.llvm.org/D114787 does the same thing and was 
> submitted a week ago.
>
> I'll try to integrate the additional testing you suggested and change this 
> patch to improve the implementation to not do the checking if not required as 
> it doesn't look entirely cheap.

I *knew* this seemed super familiar! Sorry that my search through my email 
missed that. :-D Yes, please rebase on trunk and add the improved `isIgnored()` 
check. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117232/new/

https://reviews.llvm.org/D117232

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to