kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.
Otherwise LGTM.
================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:220
- return TargetInfo::initFeatureMap(Features, Diags, CPU, FeaturesVec);
+ unsigned XLen = Features["64bit"] ? 64 : 32;
+ auto ParseResult = llvm::RISCVISAInfo::parseFeatures(XLen, FeaturesVec);
----------------
Maybe update XLen based on the if condition? that might save one StringMap
query.
```
unsigned XLen = 32;
if (getTriple().getArch() == llvm::Triple::riscv64) {
Features["64bit"] = true;
XLen = 64;
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113336/new/
https://reviews.llvm.org/D113336
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
