majnemer added inline comments.
================ Comment at: clang/lib/AST/ExprConstant.cpp:2219 + Info.getLangOpts().CPlusPlus && !isForManglingOnly(Kind) && + Var->hasAttr<DLLExportAttr>()) // FIXME: Diagnostic! ---------------- The summary and the bug both mention dllimport but this is examining dllexport. Is this intended? If so, please update the comment above this if-statement. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits