Izaron marked 4 inline comments as done.
Izaron added inline comments.
================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179
+/// consteval int bar();
+/// void baz() { if consteval {} }
+/// \endcode
----------------
aaron.ballman wrote:
> It'd be good to show an example of:
> ```
> if ! consteval {}
>
> if ! consteval {} else {}
> ```
> as well so users know what to expect.
>
> Should there be a matcher so users can distinguish between `if consteval` and
> `if ! consteval`?
>
> Test cases for these sort of things would also be appreciated.
Thanks!
> Should there be a matcher so users can distinguish between `if consteval` and
> `if ! consteval`?
This is an interesting question. I wonder how intensively `if ! consteval` is
ever going to be used in real life to make a unique matcher for it? I can't
make up a hypothetical checker that would need it.
Let's see what other fellow reviewers think about it =)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117613/new/
https://reviews.llvm.org/D117613
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
