eopXD marked 7 inline comments as done. eopXD added inline comments.
================ Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); + Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); + Builder.defineMacro("__riscv_v_max_eew_fp", Twine(MaxEewFp)); ---------------- craig.topper wrote: > khchen wrote: > > craig.topper wrote: > > > Would't ELEN be the correct term here? Not EEW. > > https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#182-zve-vector-extensions-for-embedded-processors > > shows zve* extensions have `Supported EEW`, I guess it's why the term is > > `EEW`. > > > > > Is that because that section talks about them as a set of values rather than > a single maximum? I think Zve is restricting the EEW, not ELEN. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112408/new/ https://reviews.llvm.org/D112408 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits