nickdesaulniers added a comment. In D116059#3225862 <https://reviews.llvm.org/D116059#3225862>, @efriedma wrote:
> Do we have testcases for how -Wuninitialized/-Wmaybe-uninitialized interact > with asm goto? We have tests for `-Wuninitialized`; clang/test/Analysis/uninit-asm-goto.cpp (D71314 <https://reviews.llvm.org/D71314>). Clang doesn't implement `-Wmaybe-unitialized`; perhaps you're thinking of `-Wsometimes-unitialized`? clang/test/Analysis/uninit-sometimes.cpp does not contain any `asm goto` tests (for `-Wsometimes-unitialized`). > If not, can you add them? `-Wsometimes-unitialized` is part of the diag group for `-Wunitialized`. Adding another `RUN` line to clang/test/Analysis/uninit-asm-goto.cpp that tests `-Wsometimes-unitialized` rather than `-Wunitialized` produces the same result, so unless there's a different case you can think of, I don't see testing `-Wsometimes-unitialized` w/ `asm goto` as improving our test coverage at all. > Also, an explicit test for -Warray-bounds or whatever would be nice, although > I guess the CFG tests sort of cover that. Sure, I can add one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
