owenpan added a comment.

In D116316#3224591 <https://reviews.llvm.org/D116316#3224591>, @MyDeveloperDay 
wrote:

> Owen I think we should push ahead with this rather than D95168: 
> [clang-format] Add Insert/Remove Braces option 
> <https://reviews.llvm.org/D95168> as I've looked at what you've done here I'm 
> reminded that the removal and insertion are likely mutually exclusive 
> operations.
>
> There is no doubt that insertion is desired (so I'd like to see us do that 
> afterwards) but I now think that could be in a completely separate pass as 
> you originally suggested.
>
> LGTM

Thanks! I will wait a couple of days in case other reviewers have some final 
requests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116316/new/

https://reviews.llvm.org/D116316

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to