aaron.ballman added a comment. In D88833#3222828 <https://reviews.llvm.org/D88833#3222828>, @fiesh wrote:
>> My expectation was that @fiesh would be updating the review if they wanted >> this to land. If they indicate they're no longer interested in working on >> the patch, then I think it's fine for you to commandeer the patch. But you >> should give them a chance to speak up in case they're still intending to >> finish this. @fiesh, are you expecting to work on this further? > > Oh sorry, this has somehow completely escaped my attention. I'm perfectly > fine with somebody else finalizing this patch as I will not be able to do so > in the foreseeable future. > > Happy new year! Thank you for getting back to us and getting a start on this patch! In D88833#3222843 <https://reviews.llvm.org/D88833#3222843>, @estan wrote: > And there he is :) I've never worked on LLVM / clang-tidy but could have a > look at making it opt-in. Now we know the status at least. I'd say you're clear to commandeer (the Add Action pulldown has this option). As for making it an option, a lot of other checks have config options, so you can use one of them to model your changes after, like: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp#L33 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
